refactor(sqlite): make background thread responsible for all FFI calls #1551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abonander
changed the title
abonander
force-pushed
the
ab/sqlite-refactor
branch
5 times, most recently
from
68e8b0f
to
01c1c3c
Compare
abonander
changed the title
abonander
force-pushed
the
ab/sqlite-refactor
branch
from
01c1c3c
to
c62dc87
Compare
abonander
force-pushed
the
ab/sqlite-refactor
branch
2 times, most recently
from
cc7d1a4
to
4d64b56
Compare
This was referenced Nov 23, 2021
abonander
force-pushed
the
ab/sqlite-refactor
branch
2 times, most recently
from
6943ac0
to
91cc6ac
Compare
abonander
force-pushed
the
ab/sqlite-refactor
branch
from
91cc6ac
to
6f8c357
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a significant refactor but is almost entirely internal and should be completely backwards-compatible.
There's a couple things I'm still debating, like merging
SqliteValueandSqliteArgumentValue. It doesn't make much sense to usesqlite3_value_dupto sendsqlite3_values back to the main thread when we could just eagerly convert them to their equivalent Rust types, especially since the former is going to always be heap-allocated.On further consideration, I think I'll keep
SqliteValueas it is because it technically allows access to SQLite's weak typing system by getting a value as a different type than it actually is.Closes #634
Closes #1175
Closes #1467