Add example for manual implemenation of the FromRow trait #1495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jplatte
approved these changes
Oct 15, 2021
|
If you rebase it should fix the MySQL build failure. |
Erik1000
force-pushed
the
from-row-example
branch
from
a84e699
to
ed0aaeb
Compare
|
Okay 👍 |
abonander
requested changes
Nov 5, 2021
|
Also looks like a rebase is needed. |
Erik1000
force-pushed
the
from-row-example
branch
from
95f4033
to
844342f
Compare
|
@Erik1000 I'm really sorry to have neglected this PR for so long. It got pushed onto the second page for a while, which I often forget to check. We did end up adding |
|
I'll have a look at it next week 👍 |
Co-authored-by: Jonas Platte <[email protected]>
Erik1000
force-pushed
the
from-row-example
branch
from
844342f
to
0199fa6
Compare
|
@abonander I've rebased and it's ready to be merged. |
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a discussion on the discord server, i decided to add an example for a manual implemenation of the FromRow trait. A manual implementation is useful if you can't use the derive macro (e.g. because of a external type from another crate)