fix: pool internals improvements #1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix `DecrementSizeGuard::drop()` only waking one `Waiter` regardless of whether that waiter was already woken * fix connect-backoff loop giving up the size guard * don't cut in line to open a new connection * have tasks waiting on `acquire()` wake periodically to check if there's a connection in the queue Signed-off-by: Austin Bonander <[email protected]>
|
Tested and this does fix the issues I am seeing on |
|
Can this be released as SQLx 0.5.2? We just had our SQLx DB pool get stuck without any connections to give out yesterday, hoping this will ensure that doesn't happen again. |
|
Yes. Planning to do that later today (merge in anything non-breaking and put out a 0.5.2). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DecrementSizeGuard::drop()only waking oneWaiterregardless of whether that waiter was already wokenacquire()wake periodically to check if there's a connection in the queue@dignifiedquire do you mind testing this?
Signed-off-by: Austin Bonander [email protected]