Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove any::AnyType #1007

Merged
merged 2 commits into from
Feb 1, 2021
Merged

Remove any::AnyType #1007

merged 2 commits into from
Feb 1, 2021

Conversation

jplatte
Copy link
Contributor

@jplatte jplatte commented Jan 22, 2021

It was not actually used in a meaningful way.

Copy link
Collaborator

@abonander abonander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jplatte would you take care of these warnings? (see diff)

It was not actually used in a meaningful way.
@jplatte
Copy link
Contributor Author

jplatte commented Jan 26, 2021

I took care of the warnings introduced by this PR, the other ones are fixed by #1003.

@jplatte

This comment has been minimized.

@jplatte jplatte closed this Jan 27, 2021
@jplatte jplatte reopened this Jan 27, 2021
@mehcode mehcode merged commit 5d3858d into launchbadge:master Feb 1, 2021
@mehcode
Copy link
Member

mehcode commented Feb 1, 2021

Thanks @jplatte. I don't think this helps as it stands, but deleting code is always fun to see. 😄

@jplatte
Copy link
Contributor Author

jplatte commented Feb 1, 2021

It helps avoid confusion, but not anything else, yes 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants