-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SQLx does not build if feature rust_decimal
is specified but bigdecimal
is not
#2549
Labels
Comments
I got the same problem while using version 0.7.0-alpha.3. I think rust_decimal still work on alpha 2 so not sure what problem. Right now switch to use bigdecimal |
Have this issue too on the SQLx release 0.7.0 |
This PR fixes the issue: #2585 but I don't think I linked it to this issue correctly. |
abonander
pushed a commit
that referenced
this issue
Jul 6, 2023
…using "bigdecimal" (#2585) * Fix missing num-bigint dependency for rust_decimal * Fix missing feature name change from "decimal" to "rust_decimal" * update missing "decimal"->"rust_decimal" renaming in range.rs * Update money.rs references to "decimal" * Update "decimal" -> "rust_decimal"
Hey @abonander, will we have a patch release soon? |
This was fixed by #2585 |
billy1624
added a commit
to SeaQL/sea-query
that referenced
this issue
Jul 19, 2023
…cimal` is enabled (launchbadge/sqlx#2549)" This reverts commit fa50aa2.
tyt2y3
pushed a commit
to SeaQL/sea-query
that referenced
this issue
Jul 20, 2023
* Upgrade to SQLx v0.7 * Upgrade ipnetwork to v0.20 * Encode chrono types in Any driver as string * Temporary enable `sqlx/bigdecimal` feature when `with-rust_decimal` is enabled (launchbadge/sqlx#2549) * Fixup * Fixup * Fixup * CI * Fixup * Revert "Temporary enable `sqlx/bigdecimal` feature when `with-rust_decimal` is enabled (launchbadge/sqlx#2549)" This reverts commit fa50aa2. * CI fmt checks * Bump `sea-query-binder` to v0.5.0 * Refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug Description
Minimal Reproduction
In Cargo.toml:
Info
rustc --version
: rustc 1.71.0-nightly (d3f416dc0 2023-05-18)The text was updated successfully, but these errors were encountered: