Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQLite unlock notify is not handled for BEGIN statements #2021

Closed
madadam opened this issue Aug 4, 2022 · 1 comment · Fixed by #2055
Closed

SQLite unlock notify is not handled for BEGIN statements #2021

madadam opened this issue Aug 4, 2022 · 1 comment · Fixed by #2055

Comments

@madadam
Copy link
Contributor

madadam commented Aug 4, 2022

unlock notification was implemented in #1658 but only when calling sqlite3_step. The BEGIN statement is executed using sqlite3_exec and the unlock notification is not handle there. This means that one can still get SQLITE_LOCKED_SHAREDCACHE errors when running multiple transactions concurrently.

The fix I think is to do something like this also here.

I'm happy to contribute a PR to fix this.
@abonander
Copy link
Collaborator

Please do!

madadam added a commit to madadam/sqlx that referenced this issue Aug 15, 2022
@madadam
fix: use unlock notify also on sqlite3_exec (launchbadge#2021)
e19b0c9
madadam added a commit to madadam/sqlx that referenced this issue Aug 16, 2022
@madadam
fix: use unlock notify also on sqlite3_exec (launchbadge#2021)
26df7ba
madadam added a commit to madadam/sqlx that referenced this issue Aug 16, 2022
@madadam
fix: use unlock notify also on sqlite3_exec (launchbadge#2021)
73f64ed
@madadam madadam mentioned this issue Aug 16, 2022
Merged
abonander pushed a commit that referenced this issue Aug 23, 2022
@madadam
fix: use unlock notify also on sqlite3_exec (#2021) (#2055)
2d65c5d
@raviqqe raviqqe mentioned this issue Aug 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use unlock notify also on sqlite3_exec madadam/sqlx
2 participants
@madadam @abonander