Merge pull request #565 from laughingman7743/#561

Drop support for Python 3.8 (fix #561)

.github/workflows/test.yaml

@@ -22,7 +22,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        python-version: [3.8, 3.9, "3.10", "3.11", "3.12"]
+        python-version: [3.9, "3.10", "3.11", "3.12"]
 
     steps:
       - name: Checkout

README.rst

@@ -40,7 +40,7 @@ Requirements
 
 * Python
 
-  - CPython 3.8 3.9 3.10, 3.11 3.12
+  - CPython 3.9 3.10, 3.11 3.12
 
 .. _installation:
 

docs/introduction.rst

@@ -10,7 +10,7 @@ Requirements
 
 * Python
 
-  - CPython 3.8 3.9 3.10, 3.11 3.12
+  - CPython 3.9 3.10, 3.11 3.12
 
 .. _installation:
 

pyathena/filesystem/s3.py

@@ -542,7 +542,12 @@ def touch(self, path: str, truncate: bool = True, **kwargs) -> Dict[str, Any]:
         self.invalidate_cache(path)
         return object_.to_dict()
 
-    def cp_file(self, path1: str, path2: str, **kwargs):
+    def cp_file(self, path1: str, path2: str, recursive=False, maxdepth=None, on_error=None, **kwargs):
+        # TODO: Delete the value that seems to be a typo, onerror=false.
+        # https://github.com/fsspec/filesystem_spec/commit/346a589fef9308550ffa3d0d510f2db67281bb05
+        # https://github.com/fsspec/filesystem_spec/blob/2024.10.0/fsspec/spec.py#L1185
+        # https://github.com/fsspec/filesystem_spec/blob/2024.10.0/fsspec/spec.py#L1077
+        kwargs.pop("onerror", None)
         bucket1, key1, version_id1 = self.parse_path(path1)
         bucket2, key2, version_id2 = self.parse_path(path2)
         if version_id2:

pyathena/sqlalchemy/base.py

@@ -556,6 +556,9 @@ def visit_null(self, type_, **kw):  # noqa: N802
     def visit_tinyint(self, type_, **kw):  # noqa: N802
         return self.visit_TINYINT(type_, **kw)
 
+    def visit_enum(self, type_, **kw):
+        return self.visit_string(type_, **kw)
+
 
 class AthenaDDLCompiler(DDLCompiler):
     @property

pyproject.toml

@@ -11,7 +11,7 @@ dependencies = [
     "fsspec",
     "python-dateutil",
 ]
-requires-python = ">=3.8.1"  # https://bugs.python.org/issue38342
+requires-python = ">=3.9"
 readme = "README.rst"
 license = {file = "LICENSE"}
 classifiers = [
@@ -21,7 +21,6 @@ classifiers = [
     "Operating System :: OS Independent",
     "Topic :: Database :: Front-Ends",
     "Programming Language :: Python :: 3",
-    "Programming Language :: Python :: 3.8",
     "Programming Language :: Python :: 3.9",
     "Programming Language :: Python :: 3.10",
     "Programming Language :: Python :: 3.11",
@@ -125,7 +124,7 @@ pip-compile-install-args = [
 ]
 
 [[tool.hatch.envs.test.matrix]]
-python = ["3.8", "3.9", "3.10", "3.11", "3.12"]
+python = ["3.9", "3.10", "3.11", "3.12"]
 
 [tool.pytest.ini_options]
 norecursedirs = ["benchmarks", ".venv"]
@@ -156,7 +155,7 @@ select = [
 ]
 
 [tool.mypy]
-python_version = 3.8
+python_version = 3.9
 follow_imports = "silent"
 disallow_any_generics = true
 strict_optional = true

tests/pyathena/pandas/test_util.py

@@ -307,7 +307,7 @@ def test_generate_ddl():
     )
 
     # complex
-    df = pd.DataFrame({"col_complex": np.complex_([1.0, 2.0, 3.0, 4.0, 5.0])})
+    df = pd.DataFrame({"col_complex": np.complex128([1.0, 2.0, 3.0, 4.0, 5.0])})
     with pytest.raises(ValueError):
         generate_ddl(df, "test_table", "s3://bucket/path/to/")