Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODOs in ecc/mod.rs #45

Open
1 of 5 tasks
Autoparallel opened this issue Jul 22, 2023 · 8 comments
Open
1 of 5 tasks

TODOs in ecc/mod.rs #45

Autoparallel opened this issue Jul 22, 2023 · 8 comments
Assignees

Comments

@Autoparallel
Copy link
Collaborator

Autoparallel commented Jul 22, 2023

ECC

We need to get the following done to be able to implement other issues (e.g., #34)

  • Implement reduced_ate_pairing_batch_precomputed()
  • Implement conditionally_subtract_from_double_modulus()
  • Implement tag_coset_generator()
  • Implement coset_generator()
  • Implement external_coset_generator()
@Autoparallel
Copy link
Collaborator Author

Trying to work on this now but I'm a bit lost.

We need to be able to get:

  • the modulus of the scalar field
  • coset generators

In Barettenberg these are all part of the field struct (located in field.hpp)

@Autoparallel
Copy link
Collaborator Author

@shuklaayush want to join?

@shuklaayush
Copy link
Contributor

Let's do it

@shuklaayush
Copy link
Contributor

We probably don't need reduced_ate_pairing_batch_precomputed for now as mentioned in #57

@Autoparallel
Copy link
Collaborator Author

Autoparallel commented Aug 7, 2023

  • We need to figure out how the exact values of the coset generators are attained.
    • Can we copy from Barretenberg or IDEALLY, use Arkworks?
  • Figure out the double modulus. Do we need the exact BigInt value?

@laudiacay
Copy link
Owner

whats up here @shuklaayush

@laudiacay
Copy link
Owner

oh yeah i put stubs for the coset generators. weren't we arguing about this in the chat? I decided to do something else

@laudiacay laudiacay reopened this Sep 18, 2023
@laudiacay
Copy link
Owner

laudiacay commented Sep 18, 2023

just kidding. we still need 3/4 of these, I think. but wait until a test is breaking to implement them.

Repository owner deleted a comment from CristianodaSilvaPalma Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants