Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use arkworks pairings for final pairing check #64

Merged
merged 3 commits into from
Aug 7, 2023
Merged

fix: use arkworks pairings for final pairing check #64

merged 3 commits into from
Aug 7, 2023

Conversation

shuklaayush
Copy link
Contributor

@shuklaayush shuklaayush commented Aug 2, 2023 •
edited
Loading

Nuke reduced_ate_pairing_batch_precomputed for now and use arkworks pairing

Relevant pre-optimized part in bb
https://github.com/AztecProtocol/barretenberg/blob/ad615ee7dc931d3dbea041e47c96b9d8dccebf98/cpp/src/barretenberg/srs/reference_string/file_reference_string.cpp#L13-L15

Addresses #45, #57

laudiacay
laudiacay approved these changes Aug 7, 2023
View reviewed changes
Copy link
Owner

@laudiacay laudiacay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

buenoooo

@laudiacay laudiacay merged commit 47af2f7 into laudiacay:main Aug 7, 2023
@shuklaayush shuklaayush deleted the feat/ark-pairing-check branch August 7, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laudiacay laudiacay laudiacay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shuklaayush @laudiacay