fix(store): emit MudStoreSetRecord event when registering a new schema, register SchemaTable's schema #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dk1a
reviewed
Feb 9, 2023
dk1a
previously approved these changes
Feb 9, 2023
alvrs
force-pushed
the
alvrs/schemaevent
branch
from
e1da9d5
to
89b9ca7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't emitting a
MudStoreSetRecordevent when storing to the schema table, because the schema table doesn't use the usualsetRecordpath of setting data (because that one requires the table to have a schema, so it's a circular dependency).Also, we weren't registering the SchemaTable's schema in the SchemaTable. Not too important, but good for completeness.