Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump forge-std #3344

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

chore: bump forge-std #3344

wants to merge 5 commits into from

Conversation

vdrg
Copy link
Contributor

@vdrg vdrg commented Oct 28, 2024

Fixes #2824

Had to also update the getStoreLogs test snapshot because the system's address changed for some reason. My current theory is that the compiler is just acting weird because of the new forge-std version (when compiling everything the bytecode of the system changes). Haven't been able to fully isolate the issue tho, but probably not really important?

Copy link

changeset-bot bot commented Oct 28, 2024

🦋 Changeset detected

Latest commit: 07ab863

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 25 packages
Name Type
@latticexyz/cli Patch
@latticexyz/gas-report Patch
@latticexyz/schema-type Patch
@latticexyz/store Patch
@latticexyz/world-module-erc20 Patch
@latticexyz/world-module-metadata Patch
@latticexyz/world-modules Patch
@latticexyz/world Patch
create-mud Patch
@latticexyz/common Patch
@latticexyz/config Patch
@latticexyz/dev-tools Patch
@latticexyz/explorer Patch
@latticexyz/protocol-parser Patch
@latticexyz/recs Patch
@latticexyz/stash Patch
@latticexyz/store-sync Patch
@latticexyz/react Patch
@latticexyz/store-indexer Patch
@latticexyz/block-logs-stream Patch
@latticexyz/faucet Patch
@latticexyz/abi-ts Patch
solhint-config-mud Patch
solhint-plugin-mud Patch
@latticexyz/utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@holic
Copy link
Member

holic commented Oct 30, 2024

given that the gas reports also changed, I suspect this caused a small bytecode change, prob the compiler taking a new path (even though we're not importing forge-std anywhere except in tests/scripts)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bump foundry-std
2 participants