Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip entrykit #3240

Draft
wants to merge 387 commits into
base: main
Choose a base branch
from
Draft

wip entrykit #3240

wants to merge 387 commits into from

Conversation

holic
Copy link
Member

@holic holic commented Sep 30, 2024

TODO

  • smart account
    • add storage to look up public key by credential ID
    • add indexed to owner emission so we can look up events?
    • start owner index at 1, store owner index in isOwner rather than bool
    • remove initializers
  • client
    • make paymaster configurable
    • add paymaster ABI somewhere so client can parse errors from paymaster
    • remove unused deps (radix dropdown?)
    • add complete or incomplete indicator to account button
    • add pending indicator to account button when open and incomplete?
    • figure out if state overrides can help with entrypoint needing >0.1 eth or gas estimation failures
    • add tx queue to app account (currently breaks for smart accounts due to nonce handling)
    • add EOA app account setup using signatures
    • execute an app acct tx immediately on setup to avoid factory issues
    • if we detect existing passkeys, flip the colors of "create account" vs "sign in" and autofocus the "sign in", maybe even flip the order
    • explore an app image instead of icon/title or behind icon/title (might be too hard to make look good)
    • small variant of account button with just user icon?
    • rename "app account" to "session account" and "app account client" to "session client"?
    • close modal after sign in
    • make openAccountModal return a promise that resolves once closed and a boolean if connected or not?
    • rename passkey from "MUD Account" to something else?
    • fix issues with mobile safari (notch and safe-area-inset-top)
    • pending state while all requirements are being evaluated to avoid UI jumping around on initial load
      • and cache it once we know a given account is in a good state so we can show it immediately

This reverts commit 4cb3d65.

Smart accounts use uint256/bigint for nonces, regular accounts use numbers ugh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants