-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): paginate world deploy logs #3217
Conversation
🦋 Changeset detectedLatest commit: 99e7f37 The changes in this PR will be included in the next version bump. This PR includes changesets to release 26 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
1521bb4
to
99e7f37
Compare
}; | ||
|
||
const RATE_LIMIT_ERRORS = [ | ||
// tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does this comment mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I use this as a mocked message in tests. I'm not sure it actually exists as an RPC response.
pulled out of #3215
related to #1522
closes #2729
leans on
fetchLogs
to get all logs of a given range, paginating and reducing block range as needed