Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): paginate world deploy logs #3217

Merged
merged 8 commits into from
Sep 23, 2024
Merged

feat(cli): paginate world deploy logs #3217

merged 8 commits into from
Sep 23, 2024

Conversation

holic
Copy link
Member

@holic holic commented Sep 22, 2024

pulled out of #3215
related to #1522
closes #2729

leans on fetchLogs to get all logs of a given range, paginating and reducing block range as needed

Copy link

changeset-bot bot commented Sep 22, 2024

🦋 Changeset detected

Latest commit: 99e7f37

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 26 packages
Name Type
@latticexyz/cli Patch
@latticexyz/block-logs-stream Patch
@latticexyz/world-modules Patch
mock-game-contracts Patch
@latticexyz/store-indexer Patch
@latticexyz/store-sync Patch
@latticexyz/dev-tools Patch
@latticexyz/explorer Patch
ts-benchmarks Patch
@latticexyz/abi-ts Patch
@latticexyz/common Patch
@latticexyz/config Patch
create-mud Patch
@latticexyz/faucet Patch
@latticexyz/gas-report Patch
@latticexyz/protocol-parser Patch
@latticexyz/react Patch
@latticexyz/recs Patch
@latticexyz/schema-type Patch
solhint-config-mud Patch
solhint-plugin-mud Patch
@latticexyz/stash Patch
@latticexyz/store Patch
@latticexyz/utils Patch
@latticexyz/world-module-metadata Patch
@latticexyz/world Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

};

const RATE_LIMIT_ERRORS = [
// tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does this comment mean?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use this as a mocked message in tests. I'm not sure it actually exists as an RPC response.

@holic holic merged commit 0f5b291 into main Sep 23, 2024
12 checks passed
@holic holic deleted the holic/fetch-deploy-logs branch September 23, 2024 10:27
@alvrs alvrs mentioned this pull request Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Block range greater than should be handled as a block range error message from Proxyd
2 participants