Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(guides/dictionary): first version #3044

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

docs(guides/dictionary): first version #3044

wants to merge 4 commits into from

Conversation

qbzzt
Copy link
Contributor

@qbzzt qbzzt commented Aug 17, 2024

Replacing PR #2987, which somehow got messed up

Replacing PR #2987, which somehow got messed up
Copy link

changeset-bot bot commented Aug 17, 2024

⚠️ No Changeset found

Latest commit: 3ff295e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@qbzzt
Copy link
Contributor Author

qbzzt commented Aug 17, 2024

Responses to @alvrs comments on the replaced PR:

  • Why is this part commented out?

    Because I couldn't get "events" to play nicely with Zustand and React. I figured I should publish what I have, and deal with events either when I have time, or when we have stash.

    • Why the {" "} ?

      Because without it prettier doesn't less me pass.

@ludns
Copy link
Member

ludns commented Sep 11, 2024

Can you add _msgSender and _msgValue?

docs/pages/guides/_meta.js Outdated Show resolved Hide resolved
Co-authored-by: Kevin Ingersoll <[email protected]>
@qbzzt
Copy link
Contributor Author

qbzzt commented Sep 11, 2024

Can you add _msgSender and _msgValue?

Consider it done


{

// ## Events
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we delete this if we're not using it yet?


<details>

{" "}
Copy link
Member

@holic holic Sep 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's with these? the space and indentation and formatting etc. feels off compared to the examples above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants