Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(world): add TS helpers to encode system calls #1745

Merged
merged 3 commits into from
Oct 11, 2023
Merged

feat(world): add TS helpers to encode system calls #1745

merged 3 commits into from
Oct 11, 2023

Conversation

holic
Copy link
Member

@holic holic commented Oct 11, 2023

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Oct 11, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 0c515ad

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@holic holic marked this pull request as ready for review October 11, 2023 19:07
@holic holic requested a review from alvrs as a code owner October 11, 2023 19:07
alvrs
alvrs reviewed Oct 11, 2023
View reviewed changes
packages/world/ts/encodeSystemCalls.ts Outdated
Comment on lines 11 to 15
({ systemId, functionName, args }) =>
[
systemId,
encodeFunctionData({ abi, functionName, args } as unknown as EncodeFunctionDataParameters<abi, functionName>),
] as const
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would using encodeSystemCall here work?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now you're thinkinnnnn

alvrs
alvrs previously approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@alvrs alvrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonder about the possibility of using the singular methods in the plural methods, but not blocking

@holic holic merged commit 49c3e6c into main Oct 11, 2023
11 checks passed
@holic holic deleted the holic/encode-batch-call branch October 11, 2023 19:50
@holic holic mentioned this pull request Oct 11, 2023
Merged
@holic holic mentioned this pull request Jan 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvrs alvrs alvrs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@holic @alvrs