Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): add batch call for function registering #1683

Conversation

CrazyNorman
Copy link

I plan to first implement batch calling for the function registration part in the deploy. If everything works well, I can then proceed to finish the remaining parts.

One tricky parameter is the BATCH_SIZE. It may vary based on the length of function names and the gas limit. I've chosen a conservative value for now, but I believe this can be made configurable in a certain place eventually.

fix #1645

@changeset-bot
Copy link

changeset-bot bot commented Oct 2, 2023

⚠️ No Changeset found

Latest commit: 69facc1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 2, 2023

@CrazyNorman is attempting to deploy a commit to the Lattice Team on Vercel.

A member of the Team first needs to authorize it.

@holic
Copy link
Member

holic commented Oct 30, 2023

Going to close this for now to clean up some of our open PR backlog since this is a diff against our old deploy code (overhauled in #1702)

Feel free to re-open or start a new PR when you get to this!

@holic holic closed this Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use batch call for registration methods in deploy
2 participants