Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(store,world): replace ResourceSelector with ResourceId and WorldResourceId #1544

Merged
merged 48 commits into from
Sep 21, 2023
Merged

feat(store,world): replace ResourceSelector with ResourceId and WorldResourceId #1544

merged 48 commits into from
Sep 21, 2023

Commits on Sep 19, 2023

  1. feat(store,world): add ResourceType, ResourceId

    @alvrs
    alvrs committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    436f814 View commit details
    Browse the repository at this point in the history

  2. create ResourceId user type

    @alvrs
    alvrs committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    ead0f46 View commit details
    Browse the repository at this point in the history

  3. refactor(store): use ResourceId instead of bytes32

    @alvrs
    alvrs committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    6e478cd View commit details
    Browse the repository at this point in the history

  4. intermediate commit just in case

    @alvrs
    alvrs committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    b26630a View commit details
    Browse the repository at this point in the history

  5. refactor world to use ResourceId instead of bytes32

    @alvrs
    alvrs committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    bbf982c View commit details
    Browse the repository at this point in the history

  6. rebuild artifacts

    @alvrs
    alvrs committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    c8421f0 View commit details
    Browse the repository at this point in the history

  7. gas report

    @alvrs
    alvrs committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    9d6e28a View commit details
    Browse the repository at this point in the history

  8. self-review

    @alvrs
    alvrs committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    2f80cd7 View commit details
    Browse the repository at this point in the history

  9. self-review

    @alvrs
    alvrs committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    4bc95a2 View commit details
    Browse the repository at this point in the history

  10. Create stale-seahorses-pay.md

    @alvrs
    alvrs authored Sep 19, 2023
    Configuration menu
    Copy the full SHA
    896a275 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2023

  1. improve storeEventsAbi test for accuracy and clarity

    @holic
    holic committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    9eaf761 View commit details
    Browse the repository at this point in the history

  2. fix missing indexed arg

    @holic
    holic committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    9ad7956 View commit details
    Browse the repository at this point in the history

  3. table ID -> resource ID

    @holic
    holic committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    2ce2905 View commit details
    Browse the repository at this point in the history

  4. refactor resource ID utils

    @holic
    holic committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    8ed3a75 View commit details
    Browse the repository at this point in the history

  5. add world resource types

    @holic
    holic committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    8b794df View commit details
    Browse the repository at this point in the history

  6. migrate most things

    @holic
    holic committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    b5efe9f View commit details
    Browse the repository at this point in the history

  7. fix logToTable test

    @holic
    holic committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    fd87f7b View commit details
    Browse the repository at this point in the history

  8. kick ci

    @holic
    holic committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    010e08e View commit details
    Browse the repository at this point in the history

  9. Merge branch 'main' into alvrs/resourcetype

    @alvrs
    alvrs committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    d96262c View commit details
    Browse the repository at this point in the history

  10. replace hasOwn usage for now

    @holic
    holic committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    b964236 View commit details
    Browse the repository at this point in the history

  11. prettier

    @alvrs
    alvrs committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    4b92f09 View commit details
    Browse the repository at this point in the history

  12. rename config constants from SELECTOR to NAME

    @alvrs
    alvrs committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    437002f View commit details
    Browse the repository at this point in the history

  13. move tableId back to memory in tests to make gas reports comparable

    @alvrs
    alvrs committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    1c1d774 View commit details
    Browse the repository at this point in the history

  14. Update .changeset/stale-seahorses-pay.md

    @alvrs
    alvrs authored Sep 20, 2023
    Configuration menu
    Copy the full SHA
    711cb00 View commit details
    Browse the repository at this point in the history

  15. Update .changeset/stale-seahorses-pay.md 

    Co-authored-by: Kevin Ingersoll <[email protected]>
    @alvrs @holic
    alvrs and holic authored Sep 20, 2023
    Configuration menu
    Copy the full SHA
    6fa3e89 View commit details
    Browse the repository at this point in the history

  16. Update .changeset/stale-seahorses-pay.md

    @alvrs
    alvrs authored Sep 20, 2023
    Configuration menu
    Copy the full SHA
    f317806 View commit details
    Browse the repository at this point in the history

  17. Update packages/world/src/interfaces/IModule.sol

    @alvrs
    alvrs authored Sep 20, 2023
    Configuration menu
    Copy the full SHA
    64664af View commit details
    Browse the repository at this point in the history

  18. rename errors

    @alvrs
    alvrs committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    85590fa View commit details
    Browse the repository at this point in the history

  19. fix braces

    @alvrs
    alvrs committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    3509850 View commit details
    Browse the repository at this point in the history

  20. Update packages/world/src/modules/keyswithvalue/constants.sol 

    Co-authored-by: Kevin Ingersoll <[email protected]>
    @alvrs @holic
    alvrs and holic authored Sep 20, 2023
    Configuration menu
    Copy the full SHA
    43ad722 View commit details
    Browse the repository at this point in the history

  21. Update packages/world/src/modules/keyswithvalue/getTargetTableId.sol 

    Co-authored-by: Kevin Ingersoll <[email protected]>
    @alvrs @holic
    alvrs and holic authored Sep 20, 2023
    Configuration menu
    Copy the full SHA
    c0e39f8 View commit details
    Browse the repository at this point in the history

  22. Update packages/world/src/modules/keyswithvalue/getTargetTableId.sol 

    Co-authored-by: Kevin Ingersoll <[email protected]>
    @alvrs @holic
    alvrs and holic authored Sep 20, 2023
    Configuration menu
    Copy the full SHA
    25ea104 View commit details
    Browse the repository at this point in the history

  23. run prettier

    @alvrs
    alvrs committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    202c042 View commit details
    Browse the repository at this point in the history

  24. update gas-report

    @alvrs
    alvrs committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    01e6a64 View commit details
    Browse the repository at this point in the history

  25. feat(world): use ResourceId namespaceId for all methods acting on t… 

    …he namespace as a resource (#1555)

Co-authored-by: Kevin Ingersoll <[email protected]>
    @alvrs @holic
    alvrs and holic authored Sep 20, 2023
    Configuration menu
    Copy the full SHA
    c7030fa View commit details
    Browse the repository at this point in the history

  26. remove isType

    @alvrs
    alvrs committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    4e2dcd5 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2023

  1. feat: use named args for WorldResourceIdLib and ResourceIdLib

    @alvrs
    alvrs committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    dccf072 View commit details
    Browse the repository at this point in the history

  2. reorder arguments in WorldResourceIdLib and ResourceIdLib

    @alvrs
    alvrs committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    4cfadea View commit details
    Browse the repository at this point in the history

  3. change encoding order

    @alvrs
    alvrs committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    cd90e05 View commit details
    Browse the repository at this point in the history

  4. update parser

    @alvrs
    alvrs committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    33b4f89 View commit details
    Browse the repository at this point in the history

  5. rebuild artifacts

    @alvrs
    alvrs committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    53ad81b View commit details
    Browse the repository at this point in the history

  6. Apply suggestions from code review

    @alvrs
    alvrs authored Sep 21, 2023
    Configuration menu
    Copy the full SHA
    8db70ac View commit details
    Browse the repository at this point in the history

  7. Apply suggestions from code review

    @alvrs
    alvrs authored Sep 21, 2023
    Configuration menu
    Copy the full SHA
    41d3e12 View commit details
    Browse the repository at this point in the history

  8. update test data

    @alvrs
    alvrs committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    ee4f8c7 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'main' into alvrs/resourcetype

    @alvrs
    alvrs authored Sep 21, 2023
    Configuration menu
    Copy the full SHA
    3b76172 View commit details
    Browse the repository at this point in the history

  10. Apply suggestions from code review 

    Co-authored-by: Kevin Ingersoll <[email protected]>
    @alvrs @holic
    alvrs and holic authored Sep 21, 2023
    Configuration menu
    Copy the full SHA
    e4d97bc View commit details
    Browse the repository at this point in the history

  11. update test data

    @alvrs
    alvrs committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    18aac90 View commit details
    Browse the repository at this point in the history

  12. run prettier

    @alvrs
    alvrs committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    de9124e View commit details
    Browse the repository at this point in the history