Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(schema-type): add gas-report, optimize #1155

Merged
merged 3 commits into from
Jul 13, 2023
Merged

refactor(schema-type): add gas-report, optimize #1155

merged 3 commits into from
Jul 13, 2023

Conversation

dk1a
Copy link
Contributor

@dk1a dk1a commented Jul 13, 2023 •
edited
Loading

fixes a part of #1133

@changeset-bot
Copy link

changeset-bot bot commented Jul 13, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 3624e47

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

holic
holic reviewed Jul 13, 2023
View reviewed changes
packages/schema-type/src/solidity/SchemaType.sol Outdated
@@ -211,27 +211,20 @@ enum SchemaType {
* Get the length of the data for the given schema type
* (Because Solidity doesn't support constant arrays, we need to use a function)
*/
function getStaticByteLength(SchemaType schemaType) pure returns (uint256) {
function getStaticByteLength(SchemaType schemaType) pure returns (uint256 r) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for free functions, do we not need/get any benefit from internal? (I assume not)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

free functions can't have visibility modifiers at all
effectively they're all always internal

@dk1a dk1a marked this pull request as ready for review July 13, 2023 16:07
@dk1a dk1a requested a review from alvrs as a code owner July 13, 2023 16:07
@dk1a dk1a merged commit db19ea3 into main Jul 13, 2023
@dk1a dk1a deleted the dk1a/schema-type-update branch July 13, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holic holic holic approved these changes

@alvrs alvrs Awaiting requested review from alvrs alvrs is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dk1a @holic