-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix test file name #8
Conversation
Thanks a lot for this, very much appreciated. The more I think about all this the more I think we should start an Ionic 2 Seed repo as I mentioned on the Ionic issue. You seem pretty interested in getting this stuff right, if you're interested in collaborating on something give me a shout. |
A seed project would bring some problems...
I think, a better approach would be fork and create PRs to https://github.com/driftyco/ionic2-app-base/tree/typescript so existing projects would have a easy way to check a diff, all starters would use it and would be something official. |
Agreed. On 24 February 2016 at 10:00, Júlio Cesar Bueno Cotta <
|
So... What should be our next steps?
|
Yup sounds sensible. I think an open question is whether or not the spec files should be kept with the source code. https://github.com/mgechev/angular2-style-guide I'm starting to think its nicer to keep everything together..? Do you wanna fork & maybe give a heads up on the Ionic issue so others could get involved if they want? Then we can continue the discussion on the fork. In the meantime I'll try to get my shit up to latest, but I may not be available until this evening (I'm UTC+13). |
I am also thinking about keep everything together... it seems the recommended way by angular team... |
cloned. Any chance you can enable issues / and give me push perms? If you aren't comfortable with the latter I'm happy to do PRs. On 24 February 2016 at 10:36, Júlio Cesar Bueno Cotta <
|
just a sec. |
done. |
nice - I opened a few issues on your fork just to get your thoughts / On 24 February 2016 at 10:56, Júlio Cesar Bueno Cotta <
|
Just a heads' up that this repo is now up to date. Note #9 |
No description provided.