Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protractor tests #50

Merged
merged 15 commits into from
Mar 11, 2016
Merged

Protractor tests #50

merged 15 commits into from
Mar 11, 2016

Conversation

ric9176
Copy link
Contributor

@ric9176 ric9176 commented Mar 11, 2016

Adds e2e tests :-)

@lathonez
Copy link
Owner

wow, thank you. I'm just having play with this locally to get my head around the changes.

My only comment thus far is that I wanted all the *.spec to be kept in with the source code as per the Angular 2 style guide / actual directory structure.

However, I am more than happy to take this is a great starting point.

@lathonez
Copy link
Owner

Got it up and running! Very cool..

@lathonez lathonez merged commit 9741a68 into lathonez:master Mar 11, 2016
@lathonez
Copy link
Owner

Thanks a lot for this, I've updated README with some info and shout outs to you guys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants