Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #17

Closed
wants to merge 1 commit into from
Closed

fixes #17

wants to merge 1 commit into from

Conversation

juliocbcotta
Copy link
Contributor

@juliocbcotta
Copy link
Contributor Author

@mmolhoek, those are not direct dependencies, like lodash is a angular dependencies, as far as I know, we need to wait them update, so we update the angular version.

@lathonez
Copy link
Owner

yep

On 25 February 2016 at 09:58, Júlio Cesar Bueno Cotta <
[email protected]> wrote:

@mmolhoek https://github.com/mmolhoek, those are not direct
dependencies, like lodash is a angular dependencies, as far as I know, we
need to wait them update, so we update the angular version.


Reply to this email directly or view it on GitHub
#17 (comment).

@mmolhoek
Copy link

@BugsBunnyBR ok 👍

@juliocbcotta
Copy link
Contributor Author

@lathonez , I don't know if it solves anything. I just forgot to remove that webpack lines.

@mmolhoek
Copy link

@lathonez @BugsBunnyBR it did remove a ton of warning on npm start:

ERROR in [default] /Volumes/SecureProjects/Projects/angular2/clicker/typings/main/ambient/jasmine/jasmine.d.ts:473:8
Duplicate identifier 'started'.

ERROR in [default] /Volumes/SecureProjects/Projects/angular2/clicker/typings/main/ambient/jasmine/jasmine.d.ts:474:8
Duplicate identifier 'finished'.

ERROR in [default] /Volumes/SecureProjects/Projects/angular2/clicker/typings/main/ambient/jasmine/jasmine.d.ts:475:8
Duplicate identifier 'result'.

ERROR in [default] /Volumes/SecureProjects/Projects/angular2/clicker/typings/main/ambient/jasmine/jasmine.d.ts:476:8
Duplicate identifier 'messages'.

ERROR in [default] /Volumes/SecureProjects/Projects/angular2/clicker/typings/main/ambient/jasmine/jasmine.d.ts:490:8
Duplicate identifier 'Spec'.

ERROR in [default] /Volumes/SecureProjects/Projects/angular2/clicker/typings/main/ambient/jasmine/jasmine.d.ts:491:8
Duplicate identifier 'clock'.

ERROR in [default] /Volumes/SecureProjects/Projects/angular2/clicker/typings/main/ambient/jasmine/jasmine.d.ts:492:8
Duplicate identifier 'util'.

@lathonez
Copy link
Owner

@mmolhoek this will be the tsconfig.json change?

@mmolhoek
Copy link

@lathonez yep

@juliocbcotta
Copy link
Contributor Author

@lathonez Yes, it will, for now.
@mmolhoek , the remaining lines need ionic and angular update, which are not available.

@lathonez
Copy link
Owner

lathonez added a commit that referenced this pull request Feb 24, 2016
@lathonez
Copy link
Owner

merged as 90f677d

This was sufficient to resolve all the warnings for me.

@BugsBunnyBR - thanks a lot for picking this up, will teach me to actually start the app when I make changes like this (instead of just testing). Hopefully when Ionic moves back to gulp we can use an identical compilation strategy for both.

@mmolhoek - cheers for your input on this and the other issues.

@lathonez lathonez closed this Feb 24, 2016
@lathonez lathonez mentioned this pull request Feb 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

would be nice to upgrade versions to latest compilation errors
3 participants