-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Production build fails after upgrading to ionic 2.1.0 #236
Comments
The only thing I can think of is the angular upgrade causing it?
Try downgrading to angular2.1 to see if it solves? Not a solution but I am
AFK this weekend and it gets you somewhere.
…On Sat, 11 Mar 2017 at 03:33, Vladimir Bolshutkin ***@***.***> wrote:
In clean working copy cloned from master branch with re-installed npm
dependencies running ionic build browser --prod fails with the following
error:
[19:01:01] ngc started ...
[19:01:02] build prod failed: Error encountered resolving symbol values statically. Calling function
'NoOpAnimationDriver', function calls are not supported. Consider replacing the function or lambda with a
reference to an exported function, resolving symbol AnimationDriver.NOOP in
***@***.***/platform-browser/src/dom/animation_driver.d.ts,
resolving symbol BrowserTestingModule in
***@***.***/platform-browser/testing/browser.d.ts,
resolving symbol BrowserTestingModule in
***@***.***/platform-browser/testing/browser.d.ts
[19:01:02] ionic-app-script task: "build"
[19:01:02] Error: Error encountered resolving symbol values statically. Calling function 'NoOpAnimationDriver',
function calls are not supported. Consider replacing the function or lambda with a reference to an exported
function, resolving symbol AnimationDriver.NOOP in
***@***.***/platform-browser/src/dom/animation_driver.d.ts,
resolving symbol BrowserTestingModule in
***@***.***/platform-browser/testing/browser.d.ts,
resolving symbol BrowserTestingModule in
***@***.***/platform-browser/testing/browser.d.ts
Error: Error encountered resolving symbol values statically. Calling function 'NoOpAnimationDriver', function calls are not supported. Consider replacing the function or lambda with a reference to an exported function, resolving symbol AnimationDriver.NOOP in ***@***.***/platform-browser/src/dom/animation_driver.d.ts, resolving symbol BrowserTestingModule in ***@***.***/platform-browser/testing/browser.d.ts, resolving symbol BrowserTestingModule in ***@***.***/platform-browser/testing/browser.d.ts
at simplifyInContext ***@***.***/compiler/bundles/compiler.umd.js:25703:25)
at StaticReflector.simplify ***@***.***/compiler/bundles/compiler.umd.js:25715:15)
at StaticReflector.annotations ***@***.***/compiler/bundles/compiler.umd.js:25213:62)
at NgModuleResolver.resolve ***@***.***/compiler/bundles/compiler.umd.js:17573:84)
at CompileMetadataResolver.getNgModuleMetadata ***@***.***/compiler/bundles/compiler.umd.js:18081:62)
at CompileMetadataResolver.getNgModuleSummary ***@***.***/compiler/bundles/compiler.umd.js:18037:54)
at ***@***.***/compiler/bundles/compiler.umd.js:18127:70
at Array.forEach (native)
at CompileMetadataResolver.getNgModuleMetadata ***@***.***/compiler/bundles/compiler.umd.js:18122:51)
at addNgModule ***@***.***/compiler/bundles/compiler.umd.js:24975:60)
Before upgrading to ionic 2.1.0 (commit 13a6cd6
<13a6cd6>)
it worked well.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#236>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AG5tSBGY27YP9qnIsp-kHmk7RZ66xepUks5rkYJXgaJpZM4MZoDz>
.
|
replicated |
confirmed that downgrading to angular 2.2.1 fixes (this specific problem) - not a solution |
fair few hits in angular/cli:
Suggestion seems to be excluding test.ts from build |
Straight upgrade of Ionic to angular2.4 on a starter project does not give the error, suggesting something from the testing framework must be the root cause (as suggested above) |
I fixed this in my project by adding the following to:
See also: ionic-team/ionic-app-scripts#806 |
@saschwarz thanks - confirmed working here, needed both test.ts and *.spec.ts. There was a reason we didn't do this.. |
Reason: #174 (comment) Excluding spec makes the testing imports go missing in the editor. I do hate the fact that when I change code (and my tests break), ionic serve stops working though. Maybe exlcuding spec from the main tsconfig.json is the lesser of two evils? Also presumably there's a way of configuring one's editor outside of the project's tsconfig.json |
above should sort it, added some tests for the browser build into CI as a quick win. TODO - update blog if this is legit |
This issue came up again after upgrading to Ionic 3. The cause is a |
Not happening here or on travis: https://s3.amazonaws.com/archive.travis-ci.org/jobs/220910203/log.txt I've never used cloud-angular so I guess isolated to that. |
In clean working copy cloned from master branch with re-installed npm dependencies running
ionic build browser --prod
fails with the following error:Before upgrading to ionic 2.1.0 (commit 13a6cd6) it worked well.
The text was updated successfully, but these errors were encountered: