Skip to content

Commit

Permalink
Reinstate tsconfig.json excludes for ionic build --prod addressing #236
Browse files Browse the repository at this point in the history
  • Loading branch information
lathonez committed Mar 14, 2017
1 parent 835c088 commit f75ec74
Show file tree
Hide file tree
Showing 4 changed files with 21 additions and 6 deletions.
4 changes: 4 additions & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,10 @@ before_deploy:
- ionic build android
# `ionic build android` wraps `cordova build android`, which gives a legit exit code if it fails. Ionic does not; test apk exists.
- ls ./platforms/android/build/outputs/apk/android*.apk
# test a browser prod build with ionic (#236)
- ionic platform add browser
- ionic build browser --prod
- ls ./platforms/browser/build/package.zip

deploy:
provider: script
Expand Down
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
<a name="2.9.1"></a>
# 2.9.1 (2017-03-14)

### Bug Fixes

* **Build**: Reinstate tsconfig.json excludes for `ionic build --prod` [#227](https://github.com/lathonez/clicker/issues/236) ([](https://github.com/lathonez/clicker/commit/))

<a name="2.9.0"></a>
# 2.9.0 (2017-02-27)

Expand Down
6 changes: 5 additions & 1 deletion appveyor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,8 @@ test_script:
- npm run test-ci
- npm run e2e

build: off
build:
# test a browser prod build with ionic (#236)
- ionic platform add browser
- ionic build browser --prod
- ls platforms\browser\build\package.zip
10 changes: 5 additions & 5 deletions tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,16 @@
"module": "es2015",
"moduleResolution": "node",
"sourceMap": true,
"target": "es5",
"types": [

This comment has been minimized.

Copy link
@kamok

kamok Apr 3, 2017

Why did you remove type jasmine? This broke my build process.

This comment has been minimized.

Copy link
@lathonez

lathonez Apr 3, 2017

Author Owner

Clue is in the commit message. #236

"jasmine"
]
"target": "es5"
},
"include": [
"src/**/*.ts"
],
"exclude": [
"node_modules"
"node_modules",
"src/test.ts",
"**/*.spec.ts",
"e2e"
],
"compileOnSave": false,
"atom": {
Expand Down

0 comments on commit f75ec74

Please sign in to comment.