Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completion hangs in Emacs/lsp-latex #802

Closed
vadim-zyamalov opened this issue Oct 23, 2022 · 5 comments
Closed

Completion hangs in Emacs/lsp-latex #802

vadim-zyamalov opened this issue Oct 23, 2022 · 5 comments

Comments

@vadim-zyamalov
Copy link

The problem is the same as in #456.

I use texlab in Emacs (Windows build) with lsp-mode.
Emacs version: 28.2
LSP-mode: latest from git (installed via straight)
texlab version: 4.3.0 (installed via Scoop).

Freezes start immediately after the document is opened. Emacs uses 100% its CPU core (Windows builds are single threaded). It takes Emacs 20-30 seconds on my i5 machine to respond after the autocompletion call. Fter the initial freeze I have from 0 to 2 minutes of normal work.
Interestingly, there is no freezes in Emacs 28.1 (checked on the official Windows build from GNU ftp).
@pfoerster
Copy link
Member

@d9d6ka Can you provide a log file (using texlab -vvvv --log-file ...), please? The previous version of this issue was caused by a configuration request that was not answered by Emacs.

@vadim-zyamalov
Copy link
Author

vadim-zyamalov commented Oct 23, 2022 •
edited
Loading

How should I get it correct way? I've tried this, but it doesn't work (maybe I should have lsp-latex installed).

EDIT: ok, did it. I've noticed, that Texlab in Scoop is updated up to 4.3.1. I've updated it as well. Freezing seems to be much more rare, howewer it happens time to time.

Here is the log for version 4.3.1.

texlab.log

@pfoerster
Copy link
Member

Thanks for the log file. There are some things going on, which do not seem right:

  • Emacs is sending a lot of textDocument/documentSymbols and textDocument/documentLink requests.
    In fact, there are so many that texlab cannot keep up with responding to them in-time. There is one section in the log file, where Emacs sends 7 textDocument/documentLink requests although the document has not changed in the mean time. Document symbols are particulary expensive because the whole syntax tree of the file needs to be traversed and the output can be quite large compared to other requests.
  • Emacs is cancelling finished requests. However, this is not a problem for texlab as the server does not support cancellation so the messages are discarded.
  • The colon after the drive letter is URL-encoded in incoming requests from Emacs (likely not the problem and easy to handle in texlab)

So the TLDR version is that Emacs sends way too many unnecessary requests which slow down texlab.

pfoerster added a commit that referenced this issue Oct 23, 2022
@pfoerster
Handle URIs with encoded drive letters
372e4e2 
See #802.
@pfoerster
Copy link
Member

@d9d6ka Are there updates on this issue? Does this problem still occur?

@vadim-zyamalov
Copy link
Author

@d9d6ka Are there updates on this issue? Does this problem still occur?

Yes, it seems so. I haven't bumped into the issue for a long time already. Everything works as expected! Thanks!

netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this issue Apr 27, 2023
@0-wiz-0
texlab: update to 5.5.0.
471a37e 
## [5.5.0] - 2023-04-16

### Added

- Allow optionally passing cursor position to `textDocument/build` request for use in forward search after building.
  Previously, the server had to guess the cursor position ([#475](latex-lsp/texlab#475))
- Add experimental `texlab.experimental.citationCommands` setting to allow extending the list of citation commands
  ([#832](latex-lsp/texlab#832))
- Add support for escaping placeholders in build arguments similar to forward search
- Allow configuring completion matching algorithm ([#872](latex-lsp/texlab#872))

### Fixed

- Fix regression introduced in `v5.4.2` involving `texlab.cleanArtifacts` command.

## [5.4.2] - 2023-04-11

### Fixed

- Fix memory leak when editing documents over a long time ([#856](latex-lsp/texlab#856))
- Fix parsing parentheses in file paths ([#874](latex-lsp/texlab#874))

## [5.4.1] - 2023-03-26

### Fixed

- Do not return symbols with empty names (e. g. sections without name) ([#870](latex-lsp/texlab#870))
- Repair `textDocument/formatting` request ([#871](latex-lsp/texlab#871))

## [5.4.0] - 2023-03-12

### Added

- Add experimental settings to allow extending the list of special environments:
  - `texlab.experimental.mathEnvironments`
  - `texlab.experimental.enumEnvironments`
  - `texlab.experimental.verbatimEnvironments`
- Add `texlab.changeEnvironment` workspace command ([#849](latex-lsp/texlab#849))
- Add `texlab.showDependencyGraph` workspace command

### Changed

- Do not show caption or section names in label inlay hints ([#858](latex-lsp/texlab#858))
- Include more user-defined commands in command completion

### Fixed

- Parse nested `\iffalse` blocks correctly ([#853](latex-lsp/texlab#853))
- Parse commands with multi-byte characters correctly ([#857](latex-lsp/texlab#857))
- Fix checking whether a document can be a root file

## [5.3.0] - 2023-02-25

### Added

- Allow filtering `textDocument/documentSymbols` using regular expressions specified via
  `texlab.symbols.allowedPatterns` and `texlab.symbols.ignoredPatterns`
  ([#851](latex-lsp/texlab#851))

### Fixed

- Do not use percent-encoded path when searching for PDF files during forward search
  ([#848](latex-lsp/texlab#848))
- Always return an empty list of code actions instead of returning "method not found" ([#850](latex-lsp/texlab#850))

## [5.2.0] - 2023-01-29

### Added

- Include line numbers in build warnings when available ([#840](latex-lsp/texlab#840))
- Add `none` formatter to `texlab.latexFormatter` and `texlab.bibtexFormatter` options
  to allow disabling formatting ([#846](latex-lsp/texlab#846))

### Fixed

- Concatenate more than two lines of maximum length in build diagnostics ([#842](latex-lsp/texlab#842))
- Apply the correct range of references to labels when renaming ([#841](latex-lsp/texlab#841))
- Use `document` environment to detect root file instead of `\documentclass` ([#845](latex-lsp/texlab#845))

## [5.1.0] - 2023-01-21

### Added

- Allow manually overriding the root directory using a `texlabroot`/`.texlabroot` marker file.
  See the wiki for more information.
  ([#826](latex-lsp/texlab#826), [#838](latex-lsp/texlab#838))

### Deprecated

- Deprecate `texlab.rootDirectory` setting in favor of `.texlabroot` files

### Fixed

- Do not use `.git`, `.chktexrc`, `.latexmkrc` files/directories to determine the root directory
  ([#826](latex-lsp/texlab#826))
- Fix building documents without an explicit root directory ([#837](latex-lsp/texlab#837))

## [5.0.0] - 2022-12-29

### Changed

- _BREAKING_: `texlab.rootDirectory` is now used as the folder path from which the compiler is executed
  relative to the main document. By default it is equal to `"."`. For more information, please visit the wiki.
- Improve performance of completion by a huge margin due to a faster filtering method used internally
- Do not discover project files beyond the provided workspace folders
- Try to guess the root directory by checking for files such as `.latexmkrc` or `Tectonic.toml` if `texlab.rootDirectory` is not set

### Fixed

- Update positions of reported build diagnostics when editing the affected line
- Do not treat links to files as bidirectional by default. This prevents issues where `texlab` ends up compiling the wrong file
  in projects with shared files ([#806](latex-lsp/texlab#806), [#757](latex-lsp/texlab#757), [#679](latex-lsp/texlab#679))
- Fix coverage of directories which need to be watched for changes ([#502](latex-lsp/texlab#502), [#491](latex-lsp/texlab#491))
- Resolve links of the `import` package correctly
- Use `filterText` of completion items when filtering internally ([#829](latex-lsp/texlab#829))

## [4.3.2] - 2022-11-20

### Fixed

- Do not try to run the TeX engine on package files and fail the build instead ([#801](latex-lsp/texlab#801))
- Handle URIs with URL-encoded drive letters on Windows ([#802](latex-lsp/texlab#802))
- Parse BibTeX entries with unbalanced quotes correctly ([#809](latex-lsp/texlab#809))
- Provide completion for more acronym commands ([#813](latex-lsp/texlab#813))
- Fix parsing acronym definitions ([#813](latex-lsp/texlab#813))

## [4.3.1] - 2022-10-22

### Fixed

- Do not crash with a stack overflow when trying to load packages with many internal dependencies ([#793](latex-lsp/texlab#793))
- Normalize drive letters of all document URIs
- Fix parsing commands that take file paths as arguments ([#789](latex-lsp/texlab#789))
- Use the correct working directory and command line arguments when calling `latexindent` ([#645](latex-lsp/texlab#645))
- Fix publishing to CTAN

## [4.3.0] - 2022-09-25

### Added

- Add inlay hints for `\label{...}` ([#753](latex-lsp/texlab#753))

### Fixed

- Improve accuracy of the error locations reported by the TeX engine ([#738](latex-lsp/texlab#738))
- Reduce number of false positive errors reported by `texlab` ([#745](latex-lsp/texlab#745))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pfoerster @vadim-zyamalov