Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read default config file from multiple locations #51

Merged
merged 1 commit into from
Mar 30, 2020
Merged

Read default config file from multiple locations #51

merged 1 commit into from
Mar 30, 2020

Conversation

michael-o
Copy link
Contributor

Additionally to /etc/kdcproxy.conf, load from /usr/local/etc/kdcproxy.conf
when Python has been installed manually or from a BSD pkg system.

@frozencemetery
Copy link
Member

I'm not a BSD user, so please bear with me here :)

Why can't /etc/kdcproxy.conf be used in this case? Does something stop its use?

Assuming something does, shouldn't /etc/kdcproxy.conf be preferred (i.e., first in the list)?

@michael-o
Copy link
Contributor Author

Why can't /etc/kdcproxy.conf be used in this case? Does something stop its use?

Yes, it does /etc is solely for the base system. No third-party package/port has to use it. It is completely decoupled, see hier(7). /usr/local/etc is reserved for third party package. Python lives in /usr/local son everyhing with pip lives there too.

Assuming something does, shouldn't /etc/kdcproxy.conf be preferred (i.e., first in the list)?

I'd always go from specific to generic. Just like with PATH.

frozencemetery
frozencemetery requested changes Mar 27, 2020
View reviewed changes
Copy link
Member

@frozencemetery frozencemetery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change inline. I'd like it if the commit message subject mentioned BSD - I can fix that on merge though.

kdcproxy/config/__init__.py Outdated Show resolved Hide resolved
@michael-o
Copy link
Contributor Author

@frozencemetery Change performed. Please see whether this is what you wanted. Adjust the commit as you wish.

@michael-o @frozencemetery
Support BSD-style /usr/local/etc for configuration
175b983 
On BSD systems, pkg will install python (and related components) into
the /usr/local heirarchy.  Python components are expected to store their
configuration in /usr/local/etc.

[[email protected]: commit message, wrapping]
@frozencemetery frozencemetery merged commit 112ace5 into latchset:master Mar 30, 2020
@michael-o michael-o deleted the multiple-config-locations branch March 30, 2020 21:20
@michael-o
Copy link
Contributor Author

Perfect, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frozencemetery frozencemetery frozencemetery requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michael-o @frozencemetery