New LPath File Interface #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximsmol
requested changes
Feb 17, 2024
There was a problem hiding this comment.
node.pyand thetransferstuff should be private API not public- the SDK should imo not depend on
clickor any other CLI-related stuff. it should also not write anything to stdout unless you explicitly ask - the way the i/o utils are implemented right now is very complicated in order to make the CLI experience better. Imo we should write new utils in SDK (and eventually switch CLI to use them). It'd be like 100 lines of code
ayushkamat
requested changes
Feb 17, 2024
ayushkamat
requested changes
Feb 20, 2024
maximsmol
requested changes
Feb 20, 2024
ayushkamat
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.