Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn this into a Zen Cart Plugin, for Zen Cart 1.5.8 and later #35

Closed
6 tasks done
lat9 opened this issue Apr 23, 2023 · 0 comments
Closed
6 tasks done

Turn this into a Zen Cart Plugin, for Zen Cart 1.5.8 and later #35

lat9 opened this issue Apr 23, 2023 · 0 comments

Comments

@lat9
Copy link
Owner

lat9 commented Apr 23, 2023

Per the subject, including:

  • Directory restructuring
  • Add plugin installation methd
  • Restructure language files, using zc158 array method
    • Noting that the current main language file uses constants that were presumed to be previously defined, so it needs rework.
  • Reformatting, using short-array syntax, removing extraneous spaces
  • Javascript file needs to be renamed to load; main report no longer does direct load.
  • Correct deprecations in class (dynamic properties) and main report (use of zen_db_output).

Additional changes will be pushed for other GitHub issues.

@lat9 lat9 added the change label Apr 23, 2023
@lat9 lat9 added this to the v4.0.0 milestone Apr 23, 2023
lat9 added a commit that referenced this issue Apr 23, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
lat9 added a commit that referenced this issue Apr 23, 2023
lat9 added a commit that referenced this issue Apr 23, 2023
lat9 added a commit that referenced this issue Apr 23, 2023
lat9 added a commit that referenced this issue Apr 23, 2023
lat9 added a commit that referenced this issue Apr 23, 2023
lat9 added a commit that referenced this issue Apr 23, 2023
lat9 added a commit that referenced this issue Apr 23, 2023
lat9 added a commit that referenced this issue Apr 23, 2023
lat9 added a commit that referenced this issue Apr 23, 2023
- Using short-array-syntax
- Removing unnecessary spaces
- Don't load Javascript component; it's auto-loaded by the javascript_loader.php
- Use exactly-equal syntax where warranted
- Use NULL coalesce where warranted
- File and class name changes
lat9 added a commit that referenced this issue Apr 23, 2023
... and correcting report's heading.
lat9 added a commit that referenced this issue Apr 24, 2023
@lat9 lat9 closed this as completed Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant