Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 7.3 warning for includes/classes/sales_report.php #14

Closed
webchills opened this issue Jul 8, 2019 · 0 comments
Closed

PHP 7.3 warning for includes/classes/sales_report.php #14

webchills opened this issue Jul 8, 2019 · 0 comments
Labels
bug fix provided
Milestone
v3.3.1

Comments

@webchills
Copy link

around line 1090
if (empty($timeframe['orders'])) { continue; }
is producing warnings in PHP 7.3
should be changed to break
lat9 added a commit that referenced this issue Jul 8, 2019
@lat9
#14: Correct PHP 7.3 warning
51801a5 
... per suggestion.
@lat9 lat9 added the bug label Jul 8, 2019
@lat9 lat9 added this to the v3.3.1 milestone Jul 8, 2019
@lat9 lat9 closed this as completed Aug 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug fix provided
Projects
None yet
Milestone
v3.3.1
Development

No branches or pull requests
2 participants
@webchills @lat9