New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict lifecycle-mapping to trigger the ClasspathConfigurator only for compilerIds "eclipse" or "jdt" #12

Open

kwin opened this issue Mar 7, 2017 · 1 comment

kwin commented Mar 7, 2017

Similar to https://github.com/jbosstools/m2e-jdt-compiler/blob/master/org.jboss.tools.m2e.jdt.core/lifecycle-mapping-metadata.xml the execution of this extension should be restricted to the compilerId eclipse or jdt. Otherwise running the extension is just unnecessary overhead.

The text was updated successfully, but these errors were encountered:

Member

vorburger commented Apr 8, 2017

@kwin sorry I'm only seeing & reacting to this now! Would you be willing to raise a PR for this?

vorburger added a commit to vorburger/eclipse-external-annotations-m2e-plugin that referenced this issue


          Fixed lastnpe#12: Restrict lifecycle-mapping

dce431f

Trigger the ClasspathConfigurator only for "eclipse" or "jdt" compiler.
Otherwise running the extension is just unnecessary overhead.

Similar to
https://github.com/jbosstools/m2e-jdt-compiler/blob/master/org.jboss.tools.m2e.jdt.core/lifecycle-mapping-metadata.xml

vorburger mentioned this issue

Fixed #12: Restrict lifecycle-mapping #23

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment