Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated readme to include resolvers #45

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Updated readme to include resolvers #45

wants to merge 3 commits into from

Conversation

lukeinator42
Copy link

Hi,

I updated the readme to include the resolver required for slick-migration-api.

Thanks,
Lukas

@CLAassistant
Copy link

CLAassistant commented Apr 19, 2018

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ lukeinator42
❌ Lukas Grasse


Lukas Grasse seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@lastland lastland self-requested a review April 19, 2018 20:41
@@ -53,6 +53,12 @@ Scala-Forklift supports both Slick 3.1 and Slick 3.2. The latest versions of Sca
| 2.11.x | `3.1.x` | `libraryDependencies += "com.liyaos" %% "scala-forklift-slick" % "0.2.3"` |
| 2.12.x, 2.11.x | `3.2.x` | `libraryDependencies += "com.liyaos" %% "scala-forklift-slick" % "0.3.1"` |

You might have to add these resolvers to your build.sbt file:
```
resolvers += Resolver.sonatypeRepo("snapshots")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the contribution!

If I have understood sonatypeRepo correctly, you should only need to add this resolver if you are using the snapshot version of scala-forklift, right? Or did I miss something?

If it is the case that one only needs to add this if they wants to use the snapshot version, can you modify the wording here to state that?

You might have to add these resolvers to your build.sbt file:
```
resolvers += Resolver.sonatypeRepo("snapshots")
resolvers += Resolver.jcenterRepo
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not certain what this is for?

@lastland
Copy link
Owner

Also, would you mind squashing the commit log, and commit using a GitHub ID that can sign the CLA? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants