Add check 102 to detect SY-SYSID usage
#1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larshp
reviewed
Jan 5, 2024
|
I'm not sure how to proceed with RFC enablement: Would I just call |
yes, for this scenario RFC works well when its just the statements and tokens that are used |
larshp
reviewed
Jan 5, 2024
Co-authored-by: Lars Hvam <[email protected]>
|
Thanks for the quick responses 🎉 |
|
@ConjuringCoffee you should have access to create branches in this repository now commit early and often, open a PR as draft, to get early feedback from the linter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new check finds logic utilizing the value from
SY-SYSID.I'm currently preparing for a system migration, so the name of the system will be different from before. I want to use this check to fix potential errors where logic is coupled to a specific system name.