Skip to content
This repository has been archived by the owner on Aug 26, 2022. It is now read-only.

feature:Return an error instance that extends the built-in Error object #49

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

feature:Return an error instance that extends the built-in Error object #49

wants to merge 5 commits into from

Conversation

s-hakase
Copy link
Contributor

@s-hakase s-hakase commented Apr 27, 2020 •
edited
Loading

Return an error instance that extends the built-in Error object.
This causes the captured error objects to behave the same as the built-in errors without dropping information about the Twirp errors. (e.g. can use Error.prototype.toString )

s-hakase
s-hakase commented Apr 27, 2020
View reviewed changes
pbjs-twirp/twirp.ts Outdated Show resolved Hide resolved
@s-hakase s-hakase changed the title Return TwirpError instance feature:Return an error instance that extends the built-in Error object Sep 2, 2020
@s-hakase
Copy link
Contributor Author

s-hakase commented Sep 2, 2020

@larrymyers Check it when you have time, please 🙏

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@s-hakase