Enable a minimal ESLint configuration and fix violations #178
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More comprehensive version of #154
Configuration was created with
npm run lint -- --init
(plus minor tweaks like re-allowingconsole.log
), and fixing violation was done withnpm run lint -- --fix
followed by very few minual fixes.This will also be enforced by CI to make sure future PRs respect this.
This is how the config file was created:
The
.eslintrc.yml
file created is very minimal, I recommend going through https://eslint.org/docs/rules/ to see what is important to you after this PR.npm test
so I might have removed test code that was supposed to stay.