Populate Test Suite Attributes #168
Conversation
FuadBalashov
force-pushed
the
populateTestsuitesTag
branch
2 times, most recently
from
ab44324 to
0264d28
Compare
|
Hello! As described in the commit description I have added logic to include test failures, tests, errors and time in the testsuites tag. This more closely matches the structure of the linked junit schema and makes it easier to have other infrastructure read the generated xml files for the number of failures and disabled tests. @bloveridge @larrymyers I am not sure who maintains this repo so I tagged both of you. Please let me know how to proceed! |
|
Oh, also it looks like some tests are failing with the newest version of node (8) which came out 2 days ago. I think this is an issue in master and I don't think I have touched any code related to them. |
src/junit_reporter.js
Outdated
| self.formatSuiteData = function(suite) { | ||
| return { | ||
| disabled: suite._disabled || 0, | ||
| errors: 0, |
There was a problem hiding this comment.
on second thought it probably makes sense to remove errors to reflect the structure of the inner testsuite tags.
FuadBalashov
force-pushed
the
populateTestsuitesTag
branch
from
0264d28 to
2ad72aa
Compare
|
ping: @bloveridge @larrymyers |
The specification for the testsuites tag in Junit includes multiple attributes, as per http://llg.cubic.org/docs/junit/ This commit populates disabled, errors, failures, tests and time. It does so by recursively collecting those metrics from nested testsuite tags in jasmineDone and then passing them to wrapOutputAndWriteFile.
FuadBalashov
force-pushed
the
populateTestsuitesTag
branch
from
9c29cdc to
d2bcca4
Compare
|
ping: @bloveridge @larrymyers |
1 similar comment
|
ping: @bloveridge @larrymyers |
|
@FuadBalashov I can verify the same tests failing on #170 unrelated to the changes that I've made. |
|
ping: @bloveridge @larrymyers |
|
Any movement on this? |
|
Thanks for the patch, and sorry for the abysmally slow response. |
|
Thank you @bloveridge! Any prediction on when the next release will be? |
|
It will be within the next week. There is still one more pull request that might get updated and merged in that time. Look for the new reporters version by Dec 1. |
|
Hey @bloveridge it looks like there hasn't been a release yet. Do you have an update? |
|
Just published |
|
Thank you, looking forward to using the new release |
The specification for the testsuites tag in Junit includes multiple attributes, as per: http://llg.cubic.org/docs/junit/
This commit populates disabled, errors, failures, tests and time.
It does so by recursively collecting those metrics from nested testsuite tags in
jasmineDoneand then passing them towrapOutputAndWriteFile.