fix: duplicate meta in ssr

larionov · Feb 2, 2020 · 5a02e2a · 5a02e2a
1 parent 8df4ed7
commit 5a02e2a
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 24 deletions.
diff --git a/packages/@vuepress/core/lib/client/index.ssr.html b/packages/@vuepress/core/lib/client/index.ssr.html
@@ -7,7 +7,6 @@
     <meta name="description" content="{{ description }}">
     <meta name="generator" content="VuePress {{ version }}">
     {{{ userHeadTags }}}
-    {{{ pageMeta }}}
     {{{ renderResourceHints() }}}
     {{{ renderStyles() }}}
   </head>

diff --git a/packages/@vuepress/core/lib/node/build/index.js b/packages/@vuepress/core/lib/node/build/index.js
@@ -138,14 +138,9 @@ module.exports = class Build extends EventEmitter {
     readline.cursorTo(process.stdout, 0)
     process.stdout.write(`Rendering page: ${pagePath}`)
 
-    // #565 Avoid duplicate description meta at SSR.
-    const meta = (page.frontmatter && page.frontmatter.meta || []).filter(item => item.name !== 'description')
-    const pageMeta = renderPageMeta(meta)
-
     const context = {
       url: page.path,
       userHeadTags: this.userHeadTags,
-      pageMeta,
       title: 'VuePress',
       lang: 'en',
       description: '',
@@ -225,24 +220,6 @@ function renderAttrs (attrs = {}) {
   }
 }
 
-/**
- * Render meta tags
- *
- * @param {Array} meta
- * @returns {Array<string>}
- */
-
-function renderPageMeta (meta) {
-  if (!meta) return ''
-  return meta.map(m => {
-    let res = `<meta`
-    Object.keys(m).forEach(key => {
-      res += ` ${key}="${escape(m[key])}"`
-    })
-    return res + `>`
-  }).join('')
-}
-
 /**
  * find and remove empty style chunk caused by
  * https://github.com/webpack-contrib/mini-css-extract-plugin/issues/85