Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to pest v2 #979

Merged
merged 4 commits into from
Dec 20, 2023
Merged

Upgrade to pest v2 #979

merged 4 commits into from
Dec 20, 2023

Conversation

faissaloux
Copy link
Contributor

Resolves #978

@driesvints
Copy link
Member

Thanks @faissaloux! I does seem the test suite is failing here now for some reason... could you fix that?

@faissaloux
Copy link
Contributor Author

Yeah, I don't know why that test failed! I'll check it whenever I can!

@faissaloux
Copy link
Contributor Author

faissaloux commented Dec 14, 2023

@driesvints The failed test was because of Notifications not being counted as before because of this PR laravel/framework#49030 merged in v10.33 . I think it needs Telegram env variables TELEGRAM_BOT_TOKEN TELEGRAM_CHANNEL to be passed to success, for now I have fixed the laravel/framework max version into v10.32.

Thanks for sponsoring me ❤️

composer.json Outdated Show resolved Hide resolved
wip

Verified

This commit was signed with the committer’s verified signature.
driesvints Dries Vints
@driesvints driesvints merged commit be0e54e into laravelio:main Dec 20, 2023
1 check passed
@driesvints
Copy link
Member

Thanks @faissaloux!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Pest from v1 to v2
2 participants