Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.5] Vite 3 support #77

Merged
merged 11 commits into from
Jul 19, 2022
Merged

[0.5] Vite 3 support #77

merged 11 commits into from
Jul 19, 2022

Conversation

timacdonald
Copy link
Member

@timacdonald timacdonald commented Jul 14, 2022 •
edited
Loading

Stack Testing

  • Vanilla skeleton install
    • Hot reloading (CSS + JS)
    • Blade Refreshing
  • Breeze w/ blade
    • Hot reloading (CSS + JS)
    • Blade Refreshing
  • Breeze w/ vue
    • Hot reloading (CSS + JS)
    • Blade Refreshing
  • Breeze w/ vue w/ ssr
    • Hot reloading (CSS + JS)
    • Blade Refreshing
    • SSR
  • Breeze w/ react
    • Hot reloading (CSS + JS)
    • Blade Refreshing
  • Breeze w/ react w/ ssr
    • Hot reloading (CSS + JS)
    • Blade Refreshing
    • SSR
  • Jetstream w/ livewire
    • Hot reloading (CSS + JS)
    • Blade Refreshing
  • Jetstream w/ inertia
    • Hot reloading (CSS + JS)
    • Blade Refreshing
  • Jetstream w/ inertia w/ ssr
    • Hot reloading (CSS + JS)
    • Blade Refreshing
    • SSR

Servers

  • Artisan Serve

    • Hot reloading
    • Blade Refreshing

  • Valet

    • Hot reloading
    • Blade Refreshing

  • Sail

    • Hot reloading
    • Blade Refreshing

  • Secured sites

Misc

  • Inertia helpers are not externalised in SSR build (temp fix in place)
  • Investigate resolveServerUrls.local[0]
  • Vite dev server "this is not the page you are looking for 🤚"
    • browser page
    • console logging
  • Investigate why full page refresh is triggered on storage/framework/views/** changes, triggering a double refresh.
  • It is possible to get the "this is not the page you are looking for" console log when the dev server pinged by the front-end. We should potentially check if the headers are requesting HTML
  • Update globEager usage
  • Investigate "preview"
  • CSS entries exist in the manifest

Related PRs

Things of note for upgrading projects

  • SSR output build has changed extension: bootstrap/ssr/ssr.mjs. Although we could force this to remain as .js, it looks like all future enhancements will be around modules, so I think we should stick with this as the default IMO.
  • globEager has been deprecated. You should use import.meta.glob('pattern/here/**', { eager: true }).
  • Vite no longer creates self-signed certificates and need to be manually specified (note: because of this I think there is a reason to now look at adding support for detecting Valet certs as a follow up feature).

See more details on the Vite migration guide: https://vitejs.dev/guide/migration.html

@timacdonald timacdonald mentioned this pull request Jul 14, 2022
Merged
@timacdonald timacdonald changed the title Vite 3 support [0.4.x] Vite 3 support Jul 14, 2022
@timacdonald
Copy link
Member Author

timacdonald commented Jul 14, 2022 •
edited
Loading

Updated console output...

Screen Shot 2022-07-14 at 12 17 42 pm

@timacdonald timacdonald mentioned this pull request Jul 14, 2022
Merged
timacdonald
timacdonald commented Jul 14, 2022
View reviewed changes
src/index.ts Outdated Show resolved Hide resolved
@timacdonald timacdonald mentioned this pull request Jul 14, 2022
Merged
innocenzi
innocenzi reviewed Jul 15, 2022
View reviewed changes
src/index.ts Outdated Show resolved Hide resolved
This was referenced Jul 15, 2022
Closed
Closed
@jessarcher jessarcher mentioned this pull request Jul 16, 2022
Closed
@timacdonald timacdonald mentioned this pull request Jul 17, 2022
Merged
@timacdonald timacdonald requested a review from jessarcher July 17, 2022 05:53
@jessarcher jessarcher mentioned this pull request Jul 18, 2022
Closed
@jessarcher jessarcher marked this pull request as ready for review July 19, 2022 00:45
@jessarcher jessarcher merged commit 638365e into main Jul 19, 2022
@jessarcher jessarcher changed the title [0.4.x] Vite 3 support [0.5] Vite 3 support Jul 19, 2022
@jessarcher jessarcher deleted the vite-3 branch July 19, 2022 00:47
@timacdonald
Copy link
Member Author

Thanks for the review @innocenzi ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@innocenzi innocenzi innocenzi left review comments

@jessarcher jessarcher Awaiting requested review from jessarcher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timacdonald @jessarcher @innocenzi