Remove default entry point #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The optimal entry points are different between Blade apps and SPAs so this removes the default entry point in favour of specifying them explicitly for each use case.
With no default primary entry point, it seems weird to have a default SSR entry point. This also brings equity to Vue and React set ups where React had to override the defaults with a .jsx extension.
jessarcher
force-pushed
the
remove-default-entrypoint
branch
from
d787cf4 to
5f9dfb3
Compare
timacdonald
approved these changes
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid a flash of unstyled content with Blade apps, we needed to specify a CSS entry point so that we can load a
<link rel="stylesheet">tag in HMR mode.However, for SPAs, this results in a different flash of unstyled content due to the DOM being updated slightly before the new
<link>tag is loaded. Therefore it is preferable with SPAs to import the CSS via the JavaScript entry point as we had previously.Given that it doesn't seem possible to create an optimal experience for both SPAs and Blade apps with the same default entry point(s), this PR removes the default entirely so that they must be specified explicitly.
This will of course be configured appropriatly for the stack by Breeze and Jetstream.