[0.6.x] Fail running HMR in known environments #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timacdonald
changed the title
timacdonald
force-pushed
the
fail-vapor
branch
from
55734d0 to
90450d2
Compare
timacdonald
force-pushed
the
fail-vapor
branch
from
90450d2 to
c4a4b77
Compare
|
Forge output when running
|
timacdonald
changed the title
timacdonald
force-pushed
the
fail-vapor
branch
from
de2a7ac to
9631409
Compare
|
@joedixon and I just tested this against Vapor, so it will fix issues there as well once the PR is merged and users update. Some eventual consistency going on. |
|
Converted to draft until we have the Envoyer var merged. |
|
Small nitpick: rephrase "Vite HMR server" to "Vite development server", as said server is not only for HMR - in fact, sometimes HMR is not even available |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces some nice errors for developers when running the HMR server (
npm run dev) in known environments where it shouldn't be run, specifically:The ENV check can be overridden: