Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare spark for Localization - JSON #668

Closed
wants to merge 10 commits into from
Closed

Prepare spark for Localization - JSON #668

wants to merge 10 commits into from

Conversation

Prepager
Copy link
Contributor

@Prepager Prepager commented Mar 27, 2017

I have seen quite a lot of requests and have myself ended up with the need for translating Spark. So why not get started. I have not been able to test all the pages because of the many use cases. So help with that would be appreciated!

The following issue needs to be resolved before this can be merged: laravel/framework#17923
^^ Not technically required for this specific pull request but is required if people want to extend Spark with new languages in this package.

  • Auth Views
  • Kiosk Views
  • Layouts Views
  • Modals Views
  • Nav Views
  • Settings Views
  • Shared Views
  • Root Views

@Prepager
Copy link
Contributor Author

@taylorotwell Is this the correct method?

@taylorotwell
Copy link
Member

@themsaid can review it more. I don't think you even need the en.json language file since it's the default language.

@Prepager Prepager changed the title [WIP] Prepare spark for Localization - JSON Prepare spark for Localization - JSON Mar 28, 2017
@Prepager
Copy link
Contributor Author

@taylorotwell It's not required but it does make it a lot easier for people to translate it when they have a complete language file ready. I could make it into a template file if you want to? So there is only the English part on the left side in the JSON and the right side is just blank.

@taylorotwell
Copy link
Member

I'm going to close this for now until the next major release because it will be a bigger work to do this for now. We will have to localize all English in the JavaScript as well as any English strings in the repositories, etc. I will revisit this when the time comes.

@Prepager
Copy link
Contributor Author

Prepager commented Jun 5, 2017

@taylorotwell Would you merge this anytime soon if I included JavaScript translations in this pull request too?

@blomdahldaniel
Copy link

blomdahldaniel commented Jun 14, 2017

Would really appreciate if localisation was added for the future!

@timmoh
Copy link

timmoh commented Oct 21, 2017

What about this commit??? is there a timeline when the localization will be available? perhaps we can start with the view like above... @taylorotwell @themsaid

@cord
Copy link

cord commented Oct 22, 2017

Same question here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants