-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare spark for Localization - JSON #668
Conversation
@taylorotwell Is this the correct method? |
@themsaid can review it more. I don't think you even need the en.json language file since it's the default language. |
@taylorotwell It's not required but it does make it a lot easier for people to translate it when they have a complete language file ready. I could make it into a template file if you want to? So there is only the English part on the left side in the JSON and the right side is just blank. |
I'm going to close this for now until the next major release because it will be a bigger work to do this for now. We will have to localize all English in the JavaScript as well as any English strings in the repositories, etc. I will revisit this when the time comes. |
@taylorotwell Would you merge this anytime soon if I included JavaScript translations in this pull request too? |
Would really appreciate if localisation was added for the future! |
What about this commit??? is there a timeline when the localization will be available? perhaps we can start with the view like above... @taylorotwell @themsaid |
Same question here! |
I have seen quite a lot of requests and have myself ended up with the need for translating Spark. So why not get started. I have not been able to test all the pages because of the many use cases. So help with that would be appreciated!
The following issue needs to be resolved before this can be merged:laravel/framework#17923^^ Not technically required for this specific pull request but is required if people want to extend Spark with new languages in this package.