(feat) Extract some logic to a userInstance
method.
#663
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts some of the logic of the
\Laravel\Socialite\Two\AbstractProvider::user()
method into a new\Laravel\Socialite\Two\AbstractProvider::userInstance()
method.Nothing changes, but each provider can now override
userInstance()
and had some extra logic or retrieve additional data.Probably one of the first use case could be for the
GitHub
provider and its new expiring tokens: the token response now comes with a new field calledrefresh_token_expires_in
(possiblynull
), that will can now be attached to the user in a simple way:Note:
I am not opinionated concerning the name of this method, that could be renamed.