Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Add app property #621

Merged
merged 1 commit into from
Jan 20, 2023
Merged

[5.x] Add app property #621

merged 1 commit into from
Jan 20, 2023

Conversation

driesvints
Copy link
Member

@driesvints driesvints commented Jan 20, 2023

This PR adds the app property to the base socialite manager class to prevent PHP 8.2 warnings.

Fixes #619

@driesvints driesvints changed the title Add app property [5.x] Add app property Jan 20, 2023
@taylorotwell taylorotwell merged commit a14a177 into 5.x Jan 20, 2023
@taylorotwell taylorotwell deleted the fix-app-property branch January 20, 2023 15:42
@flexchar
Copy link

@driesvints could you make a release for this? As the issue actually produces a lot of log output.

@driesvints
Copy link
Member Author

@flexchar done: v5.6.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creation of dynamic property Laravel\Socialite\SocialiteManager::$app is deprecated
3 participants