Override abstract provider for Twitter's OAuth 2.0 provider #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Twitter apps that are considered a confidential client i.e. web apps and automated bots, a basic
Authorizationheader must be passed with thegetAccessTokenResponserequest.Failure to do so results in authorisation failures when attempting to fetch the authenticated user.
Fortunately, Socialite doesn't need to be aware of the app type as sending the basic header doesn't seem to cause any issues with public Twitter apps, so I've just overridden the
getAccessTokenResponsemethod on theTwitterProviderclass to send the client ID and secret as basic username and password.Addresses #574 (Specifically, the comment here).