Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Prepare for Laravel 6.0 release #390

Merged
merged 1 commit into from
Aug 23, 2019
Merged

[4.0] Prepare for Laravel 6.0 release #390

merged 1 commit into from
Aug 23, 2019

Conversation

driesvints
Copy link
Member

No description provided.

@taylorotwell taylorotwell merged commit 8fa80eb into laravel:4.0 Aug 23, 2019
@driesvints driesvints deleted the prepare-for-release branch August 23, 2019 16:55
@GrahamCampbell
Copy link
Member

Is it not wrong to allow installation on Laravel 7, when it may not actually be compatible?

@driesvints
Copy link
Member Author

@GrahamCampbell this is the only way for apps who use socialite and want to test v7.0 already to do that. We always make sure the builds for next releases are passing (as I did today) before doing a major release

@GrahamCampbell
Copy link
Member

this is the only way for apps who use socialite and want to test v7.0 already to do that.

It's not the only way. You can just require Laravel 7 and tell composer you want to pretend it's Laravel 6 using the "as" notation. That happens in your app composer.json, which is much better than having incorrect version constraits out there in wild. You might as well just put * for the version, otherwise. :P

@driesvints
Copy link
Member Author

@GrahamCampbell Taylor prefers it this way.

@GrahamCampbell
Copy link
Member

:/

@GrahamCampbell
Copy link
Member

Defeats the object of vesion constraints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants