Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] LinkedIn provider tweaks #329

Merged
merged 3 commits into from
Jan 21, 2019
Merged

[4.0] LinkedIn provider tweaks #329

merged 3 commits into from
Jan 21, 2019

Conversation

tosty33
Copy link
Contributor

@tosty33 tosty33 commented Jan 21, 2019

The name is now displayed correctly for users outside of the USA (I had the pl_PL locale, so the "firstName.localized.en_US" returned an empty string).

Also exposed the first_name and last_name fields which is useful in the forms and populating user table columns.

@driesvints driesvints changed the title LinkedIn provider tweaks [4.0] LinkedIn provider tweaks Jan 21, 2019
@driesvints
Copy link
Member

Looks good. I've fixed the StyleCI warnings for you.

@driesvints driesvints closed this Jan 21, 2019
@driesvints driesvints reopened this Jan 21, 2019
@driesvints driesvints merged commit b50e13c into laravel:4.0 Jan 21, 2019
@driesvints
Copy link
Member

Released 4.0.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants