-
Notifications
You must be signed in to change notification settings - Fork 939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setScopes, scopes and other methods not declared in PHPDoc #647
Comments
Please see the contribution docs about docblocks and send in a PR if you want. Thanks |
I also have this issue. I get that this is not critical and it's totally fine not to fix it but why close the issue? When the issue is left open:
if possible please reopen this as it is not solved. |
adic3x
added a commit
to adic3x/socialite
that referenced
this issue
Apr 26, 2024
Added scopes, setScopes, getScopes and redirectUrl method signatures to PHPDoc (laravel#647)
Merged
taylorotwell
pushed a commit
that referenced
this issue
Apr 26, 2024
Added scopes, setScopes, getScopes and redirectUrl method signatures to PHPDoc (#647)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Socialite Version
5.8.0
Laravel Version
10.*
PHP Version
8.2.*
Database Driver & Version
No response
Description
Example from documentation (https://laravel.com/docs/10.x/socialite#access-scopes)
scopes
highlighted as non-existent method because it not declared insocialite\src\Facades\Socialite.php
https://github.com/laravel/socialite/blob/5.x/src/Facades/Socialite.php (at least in VS Code).As I understand
scopes
,setScopes
,getScopes
andredirectUrl
must be declared in PHPDoc.Steps To Reproduce
Open IDE and paste code.
The text was updated successfully, but these errors were encountered: