Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setScopes, scopes and other methods not declared in PHPDoc #647

Closed
adic3x opened this issue Jul 25, 2023 · 2 comments
Closed

setScopes, scopes and other methods not declared in PHPDoc #647

adic3x opened this issue Jul 25, 2023 · 2 comments

Comments

@adic3x
Copy link
Contributor

adic3x commented Jul 25, 2023

Socialite Version

5.8.0

Laravel Version

10.*

PHP Version

8.2.*

Database Driver & Version

No response

Description

Example from documentation (https://laravel.com/docs/10.x/socialite#access-scopes)

use Laravel\Socialite\Facades\Socialite;
 
return Socialite::driver('github')
    ->scopes(['read:user', 'public_repo'])
    ->redirect();

scopes highlighted as non-existent method because it not declared in socialite\src\Facades\Socialite.php https://github.com/laravel/socialite/blob/5.x/src/Facades/Socialite.php (at least in VS Code).

As I understand scopes, setScopes, getScopes and redirectUrl must be declared in PHPDoc.

Steps To Reproduce

Open IDE and paste code.

@driesvints
Copy link
Member

Please see the contribution docs about docblocks and send in a PR if you want. Thanks

https://laravel.com/docs/10.x/contributions#bug-reports

@Quadrubo
Copy link

I also have this issue. I get that this is not critical and it's totally fine not to fix it but why close the issue?

When the issue is left open:

  1. Someone else who knows how to fix it could stumble upon it and solve it
  2. People using socialite will discover the issue instead of trying to debug what's wrong with their setup

if possible please reopen this as it is not solved.

adic3x added a commit to adic3x/socialite that referenced this issue Apr 26, 2024
Added scopes, setScopes, getScopes and redirectUrl method signatures to PHPDoc (laravel#647)
taylorotwell pushed a commit that referenced this issue Apr 26, 2024
Added scopes, setScopes, getScopes and redirectUrl method signatures to PHPDoc (#647)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants