Pass all command line arguments to wrapped executable #728
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
sail <command> <args>
always pass<args>
to<command>
.Motivation
I found some discrepancies when using the
tinker
subcommand:artisan tinker -h
shows tinker's helpsail tinker -h
directly enters the REPLMore specifically, my use case was to load a file that takes care of performing some initialization for me. Setting the current user, maybe assigning some variables that I'll need while testing things. But that doesn't work either:
When looking at the
sail
script, I noticed that most commands forward$@
, buttinker
,mysql
,mariadb
,psql
,redis
, andopen
don't.I believe this is confusing behavior, as it makes sail differ from how the actual underlying program works (like the tinker example). If a user passes an extra argument they probably do it for a reason, so with this change every argument is passed as-is.