Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use selenium/standalone-chromium on ARM #723

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

Jubeki
Copy link
Contributor

@Jubeki Jubeki commented Sep 11, 2024

Note

There are two possible PR: This one here which only modifies the ARM image, or #722 which unifies the chromium image for both AMD and ARM.
I would be more in favour of the other PR #722, because in a multi person team, it causes less disruptions if different platforms are used.

Based on the PR laravel/docs#9875 I replaced the image which will be used on ARM, without touching the AMD part.

Description of the PR laravel/docs#9875:

This PR changes the recommended image for Sail's Selenium service on Apple Silicon from seleniarm/standalone-chromium to selenium/standalone-chromium. Notice selenium instead of seleniarm 😄

Reason: The community-maintained fork was merged back into the official Selenium project in May 2024 and is now only maintained there. See the official announcement by the Selenium project. The latest seleniarm/standalone-chromium release is Chromium v124.0.6367.78 from four months ago. Its GitHub repository is now archived. Unfortunately, until Google provides Linux/ARM builds for Chrome, Apple Silicon / ARM users still need to switch from Chrome to Chromium.

Copy link

Thanks for submitting a PR!

Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface.

Pull requests that are abandoned in draft may be closed due to inactivity.

@Jubeki Jubeki marked this pull request as ready for review September 11, 2024 10:10
@taylorotwell taylorotwell merged commit 3391b3d into laravel:1.x Sep 11, 2024
9 checks passed
@Jubeki Jubeki deleted the use-selenium-2 branch September 11, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants