Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This brings Microsoft SQL Server (their latest version) to Sail. I did it because I usually deal with clients using Azure ootb, and MSSQL it's very picky.
Because the Docker Container is very non-standard, the whole setup is done by setting a custom entrypoint. If no command is issued, the script initializes the databases (default and testing) and then starts SQL Server again but through
exec
.EULA shenanigans
The installation is done by manually accepting Microsoft SQL Server EULA, which is found on their Docker Hub. This is both required to install the database engine and the PHP extensions to connect. If the EULA is not accepted, the installation fails.
This sounds like a hurdle, but the correct thing to do is let the developer accept the EULA.
What adds and changes
sqlsrv
service.DB_ROOT_PASWORD
with a complex password (required by SQL Server)sqlsrv
andpdo_sqlsrv
only if the EULA is accepted (by default, nope).Pending work
slqsrv
to the accepted services array.sqlsrv
support with the following caveats: