Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call source .env before exporting bash environment variables ( I guess they are default values for sail ) #207

Merged
merged 1 commit into from
Jul 30, 2021

Conversation

smaruy30
Copy link
Contributor

Call source .env before exporting bash environment variables ( I guess they are default values for sail )

closes #206

@taylorotwell taylorotwell merged commit 05c2128 into laravel:1.x Jul 30, 2021
@smaruy30 smaruy30 deleted the issue206 branch July 31, 2021 05:07
@cameronmurphy
Copy link

cameronmurphy commented Aug 25, 2021

This has the effect of making the APP_PORT default value in docker-compose.yml redundant. I had configured a default APP_PORT value of 8080 in my project like so:

    ports:
        - '${APP_PORT:-8080}:80'

but the default is defined in vendor/bin/sail which means APP_PORT is never undefined and will always default to 80 when there's no value in .env. Perhaps the provided docker-compose.yml should look like this to avoid confusion:

    ports:
        - '$APP_PORT:80'

@smaruy30
Copy link
Contributor Author

@cameronmurphy
Thank you for pointing the possible confusion.
I will take a look at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to use ${APP_SERVICE} defined in .env file when executing vendor/bin/sail
3 participants